Date:	Tue, 18 May 2010 16:08:43 +0800
From:	Shaohui Zheng <shaohui.zheng@...el.com>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	Dave Hansen <dave@...ux.vnet.ibm.com>, Greg KH <gregkh@...e.de>,
	akpm@...ux-foundation.org, linux-mm@...ck.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andi Kleen <ak@...ux.intel.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-kernel@...r.kernel.org, haicheng.li@...ux.intel.com,
	shaohui.zheng@...ux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator

On Tue, May 18, 2010 at 04:44:32PM +0900, Paul Mundt wrote:
> On Tue, May 18, 2010 at 01:41:21PM +0800, Shaohui Zheng wrote:
> > On Thu, May 13, 2010 at 11:49:38AM -0700, Dave Hansen wrote:
> > > On Thu, 2010-05-13 at 11:15 -0700, Greg KH wrote:
> > > > >       echo "physical_address=0x40000000 numa_node=3" > memory/probe
> > > > > 
> > > > > I'd *GREATLY* prefer that over this new syntax.  The existing mechanism
> > > > > is obtuse enough, and the ',3' makes it more so.
> > > > > 
> > > > > We should have the code around to parse arguments like that, too, since
> > > > > we use it for the boot command-line.
> > > > 
> > > > If you are going to be doing something like this, please use configfs,
> > > > that is what it is designed for, not sysfs.
> > > 
> > > That's probably a really good point, especially since configfs didn't
> > > even exist when we made this 'probe' file thingy.  It never was a great
> > > fit for sysfs anyway.
> > > 
> > > -- Dave
> > 
> > the configfs was introduced in 2005, you can refer to http://lwn.net/Articles/148973/.
> > 
> > I enabled the configfs, and I see that the configfs is not so popular as we expected,
> > I mount configfs to /sys/kernel/config, I get an empty directory. It means that nobody is 
> > using this file system, it is an interesting thing, is it means that configfs is deprecated?
> > If so, it might not be nessarry to develop a configfs interface for hotplug.
> > 
> configfs is certainly not deprecated, but there are also not that many
> users of it at present. dlm/ocfs2 were the first users as far as I
> recall, and netconsole as well. The fact you have an empty directory just
> indicates that you don't have support for any of these enabled.
> 
> Note that there are also a lot of present-day sysfs and debugfs users
> that could/should be converted to configfs but haven't quite gotten there
> yet. In the sysfs case abuses are hard to rollback once they've made
> become part of the ABI, but that's not grounds for continuing sysfs abuse
> once cleaner methods become available. Many of the sysfs abuses were
> implemented before configfs existed.
> 
> You can also find usage guidelines and example implementations in
> Documentation/filesystems/configfs, which should give you a pretty good
> idea of whether it's a good interface fit for your particular problem or
> not.
> 
> These days sysfs seems to be the new procfs. It certainly helps to put a
> bit of planning in to the interface before you're invariably stuck with
> an ABI that's barely limping along.

Paul,
	Thanks for the clear explanation for configfs, and I kown the importance of the configfs now.
the cpu/memory probe is just an interface, we care more about whether the feature works, but the
interface implemented by sysfs or configfs, it is not important. Different paths, the same objective.
Both are for us.

we follow up the style of the majority, we also accept the feedbacks from the community. I did not 
how many efforts costs, but I am trying.

-- 
Thanks & Regards,
Shaohui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists