linux-kernel - Re: [PATCH] x86, hpet.c: Changed delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 May 2010 18:36:04 -0700
From:	Venkatesh Pallipadi <venki@...gle.com>
To:	Leonardo de Sá Alt <leonardoaltt@...il.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, hpet.c: Changed delayed_work to work when delay is 0

Thanks for sending the patch.
A comment below.

On Sat, May 15, 2010 at 8:27 AM, Leonardo de Sá Alt
<leonardoaltt@...il.com> wrote:
> Here a delayed_work was used with delay 0, so it was changed to work.
> It avoids a timer set up and the work is directly queued, providing
> less use of memory and more performance.
>
> Signed-off-by: Leonardo de Sá Alt <leonardoaltt@...il.com>
>
> ---
>  arch/x86/kernel/hpet.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> index a198b7c..4516ba1 100644
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -724,12 +724,10 @@ static int hpet_cpuhp_notify(struct notifier_block *n,
>
>        switch (action & 0xf) {
>        case CPU_ONLINE:
> -               INIT_DELAYED_WORK_ON_STACK(&work.work, hpet_work);
> +               INIT_WORK_ON_STACK(&work.work.work, hpet_work);

Can you also change work in hpet_work_struct to work_struct. That
should make things a bit more cleaner.

Thanks,
Venki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/