linux-kernel - Re: [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 May 2010 08:28:32 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Stephane Eranian <eranian@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Tom Zanussi <tzanussi@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 1/5] perf stat: add perf stat -B to pretty print large
 numbers


* Arnaldo Carvalho de Melo <acme@...radead.org> wrote:

> From: Stephane Eranian <eranian@...gle.com>
> 
> It is hard to read very large numbers so provide an 
> option to perf stat to separate thousands using a 
> separator. The patch leverages the locale support of 
> stdio. You need to set your LC_NUMERIC appropriately, 
> for instance LC_NUMERIC=en_US.UTF8. You need to pass -B 
> to activate this feature. This way existing scripts 
> parsing the output do not need to be changed. Here is an 
> example.

I've pulled it, but IMO we should go one step further: 
this feature should be made unconditional. The current 
numbers displayed by perf stat are often human-unreadable.

scripts should not parse pretty-printed output.

We used to have something like that, in the form of:

  perf record --no-samples --stat -e cycles -e instructions -a sleep 1
  perf report -n -t :

But the Newt changes broke this stat-only recording mode. 
Furthermore, there should be a --raw kind out output mode 
for perf stat as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/