linux-kernel - Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 May 2010 10:49:59 +0900
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Rupjyoti Sarmah <rsarmah@...c.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	jgarzik@...ox.com, sr@...x.de, linuxppc-dev@...abs.org
Subject: Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission >

On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah <rsarmah@...c.com> wrote:
> This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.

The controller seems to be a thrid party IP (from Synopsys) in your
SoC and there are many chances the IP will appear in some other
SOCs too. This implementation doesn't seem to take care of that
scenario.
So, please either call the driver something like sata_460ex.c
or, better still, segregate the driver in two parts - SoC specific stuff
and DWC IP core driver that can be reused by other SoCs having the
same IP in future.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/