linux-kernel - Re: [PATCH] sched: fix updating sd->balance_interval in idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 May 2010 09:16:49 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Nikhil Rao <ncrao@...gle.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Mike Galbraith <efault@....de>,
	Venkatesh Pallipadi <venki@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: fix updating sd->balance_interval in
 idle_balance()

On Wed, 2010-05-19 at 16:45 -0700, Nikhil Rao wrote:
> sd->balance_interval is updated incorrectly when SD_BALANCE_NEWIDLE is not set
> in sd->flags. This patch updates sd->balance_interval only when we balance the
> domain. 

I really need more than that.

Why is it wrong, what are the (measurable) effects of changing it and
how did it come to be this way.

I could of course go and try to reverse engineer your patch, but it
would be awesome if I didn't have to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/