linux-kernel - Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 May 2010 11:18:24 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	kosaki.motohiro@...fujitsu.com, Shaohua Li <shaohua.li@...el.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Rik van Riel <riel@...hat.com>,
	Minchan Kim <minchan.kim@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first

> On Fri, 21 May 2010, KOSAKI Motohiro wrote:
> > 
> > > Acked-by: Hugh Dickins <hughd@...gle.com>
> > > 
> > > Thanks - though I don't quite agree with your description: I can't
> > > see why the lru_cache_add_active_anon() was ever justified - that
> > > "active" came in along with the separate anon and file LRU lists.
> > 
> > If you have any worry, can you please share it? I'll test such workload
> > and fix the issue if necessary. You are expert than me in this area.
> 
> ?? I've acked the patch: my worry is only with the detail of your
> comments on the history - in my view it was always wrong to put on
> the active LRU there, and I'm glad that you have now fixed it.

Oops, I misparsed your text. very sorry. I thought you said opposite ;)

Thanks.


> If you really want to test some workload on 2.6.28 to see if it too
> works better with your fix, I won't stop you - but I'd much prefer
> you to be applying your mind to 2.6.35 and 2.6.36!
> 
> Hugh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/