linux-kernel - Re: [PATCH] mfd: section cleanup of 88pm860x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 22 May 2010 22:17:02 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Henrik Kretzschmar <henne@...htwindheim.de>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Haojian Zhuang <haojian.zhuang@...vell.com>,
	Dmitry Torokhov <dtor@...l.ru>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: section cleanup of 88pm860x driver

On Thu, Mar 25, 2010 at 21:40, Henrik Kretzschmar wrote:
_device_init(struct pm860x_chip *chip,
> -                             struct pm860x_platform_data *pdata);
> -extern void pm860x_device_exit(struct pm860x_chip *chip);
> +                             struct pm860x_platform_data *pdata) __devinit ;
> +extern void pm860x_device_exit(struct pm860x_chip *chip) __devexit ;
>
>  #endif /* __LINUX_MFD_88PM860X_H */

i took a second look and noticed that this hunk is useless.  as long
as the func definitions have proper markings, the prototypes wrt
section markings here is irrelevant.  plus, you add a spurious space
before the semicolon.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/