linux-kernel - RE: [PATCH v2] slub: move kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 23 May 2010 21:15:36 +0800
From:	"Shi, Alex" <alex.shi@...el.com>
To:	Pekka Enberg <penberg@...helsinki.fi>,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>
CC:	"cl@...ux.com" <cl@...ux.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"yanmin_zhang@...ux.intel.com" <yanmin_zhang@...ux.intel.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rjw@...k.pl" <rjw@...k.pl>
Subject: RE: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

sure. glad to a fix on this! 
 

-----Original Message-----
From: Pekka Enberg [mailto:penberg@...helsinki.fi] 
Sent: 2010年5月22日 16:36
To: Duyck, Alexander H
Cc: cl@...ux.com; linux-mm@...ck.org; Shi, Alex; yanmin_zhang@...ux.intel.com; akpm@...ux-foundation.org; linux-kernel@...r.kernel.org; rjw@...k.pl
Subject: Re: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

Alexander Duyck wrote:
> This patch is meant to improve the performance of SLUB by moving the 
> local kmem_cache_node lock into it's own cacheline separate from kmem_cache.
> This is accomplished by simply removing the local_node when NUMA is enabled.
> 
> On my system with 2 nodes I saw around a 5% performance increase w/ 
> hackbench times dropping from 6.2 seconds to 5.9 seconds on average.  
> I suspect the performance gain would increase as the number of nodes 
> increases, but I do not have the data to currently back that up.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>

Thanks for the fix, Alexander!

Yanmin and Alex, can I have your Tested-by or Acked-by please so we can close "[Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e" 
after this patch is merged?

			Pekka