linux-kernel - Re: [PATCH -mm 1/1] ptrace: PTRACE_GETFDPIC: fix the unsafe usage of child->mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100525102345.GA23574@redhat.com>
Date:	Tue, 25 May 2010 12:23:45 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mike Frysinger <vapier@...too.org>, linux-sh@...r.kernel.org,
	Paul Mundt <lethal@...ux-sh.org>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 1/1] ptrace: PTRACE_GETFDPIC: fix the unsafe usage
	of child->mm

On 05/25, David Howells wrote:
>
> Roland McGrath <roland@...hat.com> wrote:
>
> > The mm pointer is only used by these uncommon ptrace operations
>
> Like PEEKTEXT and POKETEXT?

They use access_process_vm().

According to grep, mm is only use to read a couple of members.

Perhaps can even add the simple helper

	struct mm_xxx {
		unsigned long start_code, end_code, start_data, end_data;
		... some more ...
	};

	int get_mm_xxx(struct task_struct *tracee, struct mm_xxx *mm_xxx)
	{
		struct mm_struct *mm = get_task_mm(tracee);
		...
	}

Except:

	- arch/um/kernel/ptrace.c PTRACE_SWITCH_MM does something
	  really strange

	- arch/blackfin/kernel/ptrace.c:is_user_addr_valid()
	  needs mmap_sem around find_vma()

	  The lockless access to mm->context.sram_list doesn't look
	  safe to me.

	  If we add get_task_mm() - this protects us against
	  destroy_context() only. What is the tracee's sub-thread
	  does sys_sram_alloc() or sys_sram_free() in parallel?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/