linux-kernel - Re: [PATCH] rtc: AB8500 RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 May 2010 12:09:04 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Rabin VINCENT <rabin.vincent@...ricsson.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>,
	Virupax SADASHIVPETIMATH 
	<virupax.sadashivpetimath@...ricsson.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	Srinidhi KASAGAR <srinidhi.kasagar@...ricsson.com>
Subject: Re: [PATCH] rtc: AB8500 RTC driver

On Wed, 26 May 2010 17:41:51 +0530
Rabin VINCENT <rabin.vincent@...ricsson.com> wrote:

> All your other comments should be addressed in the updated patch below.
> Thanks.

<generates the diff>


> diff -puN drivers/rtc/Kconfig~rtc-ab8500-rtc-driver-update drivers/rtc/Kconfig
> --- a/drivers/rtc/Kconfig~rtc-ab8500-rtc-driver-update
> +++ a/drivers/rtc/Kconfig
> @@ -614,7 +614,6 @@ config RTC_DRV_AB3100
>  config RTC_DRV_AB8500
>  	tristate "ST-Ericsson AB8500 RTC"
>  	depends on AB8500_CORE
> -	default y
>  	help
>  	  Select this to enable the ST-Ericsson AB8500 power management IC RTC
>  	  support. This chip contains a battery- and capacitor-backed RTC.
> diff -puN drivers/rtc/rtc-ab8500.c~rtc-ab8500-rtc-driver-update drivers/rtc/rtc-ab8500.c
> --- a/drivers/rtc/rtc-ab8500.c~rtc-ab8500-rtc-driver-update
> +++ a/drivers/rtc/rtc-ab8500.c
> @@ -46,16 +46,25 @@
>  #define COUNTS_PER_SEC			(0xF000 / 60)
>  #define AB8500_RTC_EPOCH		2000
>  
> +static const unsigned long ab8500_rtc_time_regs[] = {
> +	AB8500_RTC_WATCH_TMIN_HI_REG, AB8500_RTC_WATCH_TMIN_MID_REG,
> +	AB8500_RTC_WATCH_TMIN_LOW_REG, AB8500_RTC_WATCH_TSECHI_REG,
> +	AB8500_RTC_WATCH_TSECMID_REG
> +};
> +
> +static const unsigned long ab8500_rtc_alarm_regs[] = {
> +	AB8500_RTC_ALRM_MIN_HI_REG, AB8500_RTC_ALRM_MIN_MID_REG,
> +	AB8500_RTC_ALRM_MIN_LOW_REG
> +};

Well, it wasn't necessary to move these into file-global scope.  It
would be nicer to leave them in function scope, really.  I was just
pointing out that the `static' was missing, although unnecessary due to
compiler magic.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/