linux-kernel - [PATCH] Input: ads7846: Fix warning about output format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed,  2 Jun 2010 08:50:29 +0200
From:	Thomas Weber <weber@...science.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Thomas Weber <weber@...science.de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] Input: ads7846: Fix warning about output format

This patch fixes a compiler warning about wrong output format.

drivers/input/touchscreen/ads7846.c: In function 'ads7846_probe':
drivers/input/touchscreen/ads7846.c:1167: warning: format '%ld' expects
type 'long int', but argument 4 has type 'int'

Introduced by commit 067fb2f648543894ce775082c5636f4c32b99e4f ("Input:
ads7846 - return error on regulator_get() failure").

The ERR_PTR returns a long so the variable err needs to be long.

Signed-off-by: Thomas Weber <weber@...science.de>
---
 drivers/input/touchscreen/ads7846.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 634f6f6..9ba7d2e 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -885,7 +885,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)
 	struct spi_message		*m;
 	struct spi_transfer		*x;
 	int				vref;
-	int				err;
+	long				err;
 
 	if (!spi->irq) {
 		dev_dbg(&spi->dev, "no IRQ?\n");
@@ -1170,7 +1170,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)
 
 	err = regulator_enable(ts->reg);
 	if (err) {
-		dev_err(&spi->dev, "unable to enable regulator: %d\n", err);
+		dev_err(&spi->dev, "unable to enable regulator: %ld\n", err);
 		goto err_put_regulator;
 	}
 
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/