linux-kernel - Re: [PATCH] swiotlb-0.8.2: seperation of physical/virtual address translation and core memory allocation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Jun 2010 11:42:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	albert_herranz@...oo.es, fujita.tomonori@....ntt.co.jp,
	linux-kernel@...r.kernel.org, jeremy@...p.org,
	iommu@...ts.linux-foundation.org, linux@....linux.org.uk,
	dwmw2@...radead.org, chrisw@...s-sol.org,
	Ian.Campbell@...citrix.com, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] swiotlb-0.8.2: seperation of physical/virtual address
 translation and core memory allocation.

On Fri,  4 Jun 2010 13:52:30 -0400
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:

> Please include the following patches, located at this git tree:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb-2.6.git swiotlb-0.8.2
> 
> in your -mm tree.

I don't put individual git trees into -mm any more - I get them from
linux-next.

I could grab the individual patches but I don't see that this gains
anyone anything.  I'd suggest that you ask Stephen to include this tree
in linux-next then ask Linus to pull it into 2.6.36-rc1.

> [nice description]

The sad thing is that this description will get lost because it isn't
attached to a particular patch.  So what I do is to copy the nice
covering description into the changelog for [patch 1/n] and then, after
it I put the text

This patch:

and then follow it with the specific description for [patch 1/n].  I
suggest that you make such change in this tree.

It's not a very good solution because anyone who is looking at [patch
5/n] isn't likely to think to look in some other patch for the overall
story.  I guess it would be better if patches 2..n included the text
"see <patch name> for a description of this work" or similar.

Even better would be if git understood this workflow - if it was able
to take commentary-only commits and to bidirectionally link those
commentaries to the invividual commits which they describe.

The patches themselves look good and suitably reviewed to me.  My one
very minor comment is that include/linux/swiotlb.h ends up with a
mixture of "enum dma_data_direction dir" and "enum dma_data_direction
direction", which could be cleaned up.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/