linux-kernel - Re: [tip:x86/urgent] x86, hweight: Fix UML boot crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jun 2010 07:32:20 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	jdike@...toit.com, bharrosh@...asas.com, bp@...en8.de,
	akpm@...ux-foundation.org, toralf.foerster@....de,
	tglx@...utronix.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86, hweight: Fix UML boot crash

On Thu, Jun 10, 2010 at 00:43, H. Peter Anvin <hpa@...ux.intel.com> wrote:
> Note: I have applied this  because it fixes a regression, but it bugs

You seem to have pushed the wrong one, from this/the old thread (new one has
`resent' in the subject)?

> the living bejeezus out of me that the saner patch:
>
> diff --git a/arch/um/include/asm/arch_hweight.h
> b/arch/um/include/asm/arch_hweight.h
> new file mode 100644
> index 0000000..c656cf4
> --- /dev/null
> +++ b/arch/um/include/asm/arch_hweight.h
> @@ -0,0 +1,6 @@
> +#ifndef _ASM_UM_HWEIGHT_H
> +#define _ASM_UM_HWEIGHT_H
> +
> +#include <asm-generic/bitops/arch_hweight.h>
> +
> +#endif
>
> ... supposedly didn't work.  As such, I consider this a temporary kluge
> until a proper solution is found.  From a code-cleanliness perspective,
> this patch is awful.

It does work, but it needs `make clean' first.

Probably the kbuild dependency system doesn't handle new include files
appearing earlier in the include path than an existing include file.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/