linux-kernel - Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jun 2010 00:50:20 -0700
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Tao Ma <tao.ma@...cle.com>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Nick Piggin <npiggin@...e.de>
Subject: Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence.

On Fri, Jun 11, 2010 at 09:19:45AM +0200, Christoph Hellwig wrote:
> On Fri, Jun 11, 2010 at 03:16:13PM +0800, Tao Ma wrote:
> > oh, that would be much work for ocfs2 to do from my perspective. So I 
> > would really want to leave it as-is and I have add it to my to-do list.
> 
> Oh right, you start a new transaction there.  Sorry, ignore my request
> and keep it as it is for now.  I don't think doing truncatate in separate
> transactions actually is correct, though but that's no change with this
> patch.

Christoph,
	You're missing the part where actual truncate (reduce i_size)
sets i_size in ocfs2_truncate_file().  So this later code doesn't get
triggered for the truncate case.  It exists for the extend case, where
we extend the allocation in multiple clean transactions, then finally
set i_size in a final transaction.

Joel

-- 

"When choosing between two evils, I always like to try the one
 I've never tried before."
        - Mae West

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/