linux-kernel - Re: [PATCH] tty: Add EXTPROC support for LINEMODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Jun 2010 16:13:31 +0100
From:	Derek Fawcus <dfawcus@...co.com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: Add EXTPROC support for LINEMODE

On Tue, Jun 15, 2010 at 01:23:43PM -0700, Howard Chu wrote:
> 
> Closest thing I've found so far is for HPUX 11i Version 2:
> http://docs.hp.com/en/B2355-90848docs/B2355-90848docs.pdf
> 
> TIOCREMOTE This ioctl puts the STREAMS pty in and out of Remote Mode. When

> TIOCSIGNAL This ioctl allows the master process to send a signal to the slave

> <<<<
> 
> TIOCREMOTE seems to be the SVR4 analogue to TIOCPKT without any of the useful parts; it doesn't include the prefix
> byte, so it doesn't provide any state change information.

TIOCREMOTE is also supported on BSDs.
A program I've been playing with on and off for a few years uses it (on solaris, FreeBSD, Darwin).

That in combination with turning off all output post processing,  and then regularly sampling the
status of the pty for the following generally works:

static int
internal_get_modes (int fd, int *modep)
{
        int modes = 0;

        if (tcgetattr(fd, &tty_mode) < 0)
                return 0;

        if (tty_mode.c_lflag & ICANON)
                modes |= MODE_CANON;
        else if (tty_mode.c_lflag & ISIG)
                modes |= MODE_CBREAK;
        else
                modes |= MODE_RAW;
        if (tty_mode.c_lflag & ECHO)
                modes |= MODE_ECHO;

        if (tty_mode.c_cc[VINTR] != vdisable) modes |= MODE_INTR;
        if (tty_mode.c_cc[VQUIT] != vdisable) modes |= MODE_QUIT;
        if (tty_mode.c_cc[VSUSP] != vdisable) modes |= MODE_SUSP;

        *modep = modes;

        return 1;
}

There is obviously a race condition in detecting the change in the above,  but usually this
is only an issue when starting/stopping certain curses apps,  and can be handled by the various
app redraw command.

Currently for Linux,  I disable echo before feeding characters to the pty,  then restore it
to its previous state.  So REMOTE mode would be useful.

Sending signals to the terminal group is different for BSD/solaris/Linux:

int master_signal_tcpgrp (int master_fd, unsigned signo)  // BSD
{
        return ioctl(master_fd, TIOCSIG, signo);
}

int master_signal_tcpgrp (int master_fd, unsigned signo)  // Linux
{
        pid_t tcpgrp;

        tcpgrp = tcgetpgrp(master_fd);
        if (tcpgrp == -1) {
                return -1;
        }

        return kill(-tcpgrp, signo);
}

int master_signal_tcpgrp (int master_fd, unsigned signo)  // SVR4
{
        return ioctl(master_fd, TIOCSIGNAL, signo);
}

Now for a notification type packet mode extension,  something which provided the
information extracted in the above set of MODE change indications would be useful,
since it would remove the race condition.  i.e. a completely different interpretation
of the packet when supplying the control info.

DF
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/