linux-kernel - Re: [PATCH 12/31] tty: serial - fix tty back references in termios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jun 2010 11:50:57 -0700
From:	Tony Luck <tony.luck@...el.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Frederic Weisbecker <fweisbec@...il.com>,
	John Kacur <jkacur@...hat.com>, Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 12/31] tty: serial - fix tty back references in termios

A couple of build breaks in linux-next (tag: next-20100617)

drivers/serial/ioc4_serial.c:1750: error: expected statement before ‘)’ token

Would have a similar one for ioc3_serial.c if my .config included it.

On Tue, Jun 1, 2010 at 1:52 PM, Arnd Bergmann <arnd@...db.de> wrote:
> diff --git a/drivers/serial/ioc3_serial.c b/drivers/serial/ioc3_serial.c
> index f164ba4..bd2e9e6 100644
> --- a/drivers/serial/ioc3_serial.c
> +++ b/drivers/serial/ioc3_serial.c
 ...
> -       if (I_IGNPAR(state->port.tty))
> +       if (iflag & IGNPAR))

Can we have matching numbers of "(" and ")" here please.

> diff --git a/drivers/serial/ioc4_serial.c b/drivers/serial/ioc4_serial.c
> index 8ad28fc..2c30023 100644
> --- a/drivers/serial/ioc4_serial.c
> +++ b/drivers/serial/ioc4_serial.c
 ..
.-               if (I_IGNPAR(state->port.tty))
+               if (iflag & IGNPAR))

Same here.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/