lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jun 2010 10:51:39 +0900 (JST) From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> To: linux-kernel@...r.kernel.org Cc: kosaki.motohiro@...fujitsu.com, rientjes@...gle.com, akpm@...ux-foundation.org, balbir@...ibm.com, oleg@...hat.com Subject: Re: + oom-sacrifice-child-with-highest-badness-score-for-parent-protect-dereferencing-of-tasks-comm.patch added to -mm tree > > The patch titled > oom: protect dereferencing of task's comm > has been added to the -mm tree. Its filename is > oom-sacrifice-child-with-highest-badness-score-for-parent-protect-dereferencing-of-tasks-comm.patch > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find > out what to do about this > > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ > > ------------------------------------------------------ > Subject: oom: protect dereferencing of task's comm > From: David Rientjes <rientjes@...gle.com> > > Andrew notes that dereferencing task->comm is unsafe without holding > task_lock(task). That's true even when dealing with current, so all > existing dereferences within the oom killer need to ensure they are > holding task_lock() before doing so. > > This avoids using get_task_comm() because we'd otherwise need to allocate > a string of TASK_COMM_LEN on the stack (or add synchronization and use a > global string) and we don't want to do that because page allocations, and > thus the oom killer, can happen particularly deep in the stack. > > Reported-by: Andrew Morton <akpm@...ux-foundation.org> > Signed-off-by: David Rientjes <rientjes@...gle.com> > Cc: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> > Cc: Balbir Singh <balbir@...ibm.com> > Cc: Oleg Nesterov <oleg@...hat.com> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists