linux-kernel - [PATCH 5/6 v2]kernel:module.c variable 'nowarn' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 19 Jun 2010 13:39:13 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	rusty@...tcorp.com.au
Cc:	linux-kernel@...r.kernel.org, geert@...ux-m68k.org,
	"Justin P. Mattock" <justinmattock@...il.com>
Subject: [PATCH 5/6 v2]kernel:module.c variable 'nowarn' set but not used

This is a resend from the original, due to the original being wrong,
and having whitespace issues.
The below patch marks the variable nowarn __unused to satisfy gcc 4.6.0 from
giving this warning:
  CC      kernel/module.o
kernel/module.c: In function 'add_usage_links':
kernel/module.c:1343:6: warning: variable 'nowarn' set but not used
after doing this the warning message goes away, but checkpatch.pl
gives a warning about externs should be avoided, so am not sure
this is the right approach(but could be wrong).

 Signed-off-by: Justin P. Mattock <justinmattock@...il.com>

---
 kernel/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 8c6b428..765bac5 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1340,7 +1340,7 @@ static void add_usage_links(struct module *mod)
 {
 #ifdef CONFIG_MODULE_UNLOAD
 	struct module_use *use;
-	int nowarn;
+	int nowarn __attribute__((unused));

 	mutex_lock(&module_mutex);
 	list_for_each_entry(use, &mod->target_list, target_list) {
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/