linux-kernel - Re: [PATCH] ds2782: Fix ds2782_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jun 2010 09:35:09 +1200
From:	Ryan Mallon <ryan@...ewatersys.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
CC:	mike@...pulab.co.il, linux-kernel@...r.kernel.org,
	vilensky@...pulab.co.il, mike.rapoport@...il.com
Subject: Re: [PATCH] ds2782: Fix ds2782_get_capacity return value

On 06/15/2010 12:44 PM, Ryan Mallon wrote:
> The ds2782_get_capacity function should return 0 on success, not the
> capacity value.
> 
> Signed-off-by: Ryan Mallon <ryan@...ewatersys.com>
> ---
>  drivers/power/ds2782_battery.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
> index d762a0c..2afbeec 100644
> --- a/drivers/power/ds2782_battery.c
> +++ b/drivers/power/ds2782_battery.c
> @@ -163,7 +163,7 @@ static int ds2782_get_capacity(struct ds278x_info *info, int *capacity)
>  	if (err)
>  		return err;
>  	*capacity = raw;
> -	return raw;
> +	return 0;
>  }
>  
>  static int ds2786_get_current(struct ds278x_info *info, int *current_uA)

Ping, Anton?

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan@...ewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/