linux-kernel - Re: [PATCH] tracing: Fix undelared ENOSYS in include/linux/tracepoint.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jun 2010 11:47:12 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Wu Zhangjin <wuzhangjin@...il.com>, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <mhiramat@...hat.com>
Subject: Re: [PATCH] tracing: Fix undelared ENOSYS in
	include/linux/tracepoint.h

* Steven Rostedt (rostedt@...dmis.org) wrote:
> On Mon, 2010-06-21 at 19:09 +0800, Wu Zhangjin wrote:
> > From: Wu Zhangjin <wuzhangjin@...il.com>
> > 
> > The header file include/linux/tracepoint.h may be included without
> > include/linux/errno.h and then the compiler will fail on building for
> > undelcared ENOSYS. This patch fixes this problem via including <linux/errno.h>
> > to include/linux/tracepoint.h.
> > 
> 
> Hi Wu,
> 
> I have not hit this. Did you hit this with mips? Does it need to get
> into 2.6.35 or can it wait till 2.6.36?

errno.h is included by sched.h, which is included almost everywhere. No
wonder it took that much time for someone to hit the problem. But given
it's a simple bug fix, it should fit into the "for-2.6.35" definition,
although I am no expert in these definitions. ;-)

Thanks,

Mathieu

> 
> -- Steve
> 
> > Signed-off-by: Wu Zhangjin <wuzhangjin@...il.com>
> > ---
> >  include/linux/tracepoint.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> > index 9a59d1f..103d1b6 100644
> > --- a/include/linux/tracepoint.h
> > +++ b/include/linux/tracepoint.h
> > @@ -14,6 +14,7 @@
> >   * See the file COPYING for more details.
> >   */
> >  
> > +#include <linux/errno.h>
> >  #include <linux/types.h>
> >  #include <linux/rcupdate.h>
> >  
> 
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/