linux-kernel - Re: [PATCH UPDATED] sched: adjust when cpu_active and cpuset configurations are updated during cpu on/offlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jun 2010 23:20:12 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Tony Luck <tony.luck@...el.com>
CC:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH UPDATED] sched: adjust when cpu_active and cpuset 	configurations
 are updated during cpu on/offlining

Hello,

On 06/21/2010 11:15 PM, Tony Luck wrote:
> The history is that __exit functions are those that are called on module
> unload.  When a driver is built-in to the kernel, it can obviously never
> be unloaded. Therefore the __exit code must just be bloat for the built-in
> case.

I see.

> A system built with CONFIG_HOTPLUG_CPU=n meets the requirement
> that cpus will not be removed after system boot. So why do I need to
> include the __cpuexit code that should only be used to remove cpus?

I'm primarily curious why different archs are doing things
differently, which causes confusion and reduces test coverage.  Also,
if you just think about the end result, what x86 is doing makes more
sense.  Although it may end up with larger kernel image, it actually
allows more to be dropped once init is complete.  Anyways, will send a
patch to change those __cpuexit's to __cpuinit's.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/