linux-kernel - Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Jun 2010 05:47:09 -0700
From:	Dale Farnsworth <dale@...nsworth.org>
To:	Wan ZongShun <mcuos.com@...il.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Andrew Morton <akpm@...ux-foundation.org>,
	rtc-linux <rtc-linux@...glegroups.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm
	for max6900

On Tue, Jun 22, 2010 at 05:09:03PM +0800, Wan ZongShun wrote:
> Use rtc_valid_tm to check returning tm for max6900,
> it can avoid returning wrong tm value.
> ---
>  drivers/rtc/rtc-max6900.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
> index a4f6665..486142c 100644
> --- a/drivers/rtc/rtc-max6900.c
> +++ b/drivers/rtc/rtc-max6900.c
> @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
>  		      bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
>  	tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
> 
> -	return 0;
> +	return rtc_valid_tm(tm);
>  }
> 
>  static int max6900_i2c_clear_write_protect(struct i2c_client *client)

Ack.

Thanks,
-Dale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/