linux-kernel - Re: [PULL] param sysfs oops (simple, leaky) fix, bool arrays fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jun 2010 19:50:11 +0300
From:	Phil Carmody <ext-phil.2.carmody@...ia.com>
To:	ext Rusty Russell <rusty@...tcorp.com.au>
Cc:	"dedekind1@...il.com" <dedekind1@...il.com>,
	Takashi Iwai <tiwai@...e.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sitsofe Wheeler <sitsofe@...oo.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Christof Schmitt <christof.schmitt@...ibm.com>
Subject: Re: [PULL] param sysfs oops (simple, leaky) fix, bool arrays fix

On 06/05/10 04:28 +0200, ext Rusty Russell wrote:
> On Wed, 5 May 2010 06:19:29 pm Artem Bityutskiy wrote:
> > > Fixing in the way of the later upstream is a bit too intrusive as a
> > > stable patch.  So, I'm also not sure whether we should take it,
> > > too...
> > 
> > To be frank I do not really understand what you mean.
> > 
> > Anyway, I just humbly suggest not to have the "no one uses that, let's
> > have a leak" attitude. I do understand that this is a 'it's a lot of
> > churn for not much gain'. However, I think the rmmod leak is large
> > enough issue.
> 
> Thanks Artem, that's exactly the kind of feedback we need.
> 
> For most people, module parameters are rare, and module removal is rare.
> So the amount of leak is less than the size of the code we would add to fix
> it.
> 
> If this is hitting you, it clearly changes the priorities.  I will include
> the patches now.

Rusty,

Artem's passed the baton over to me to investigate, so I've reviewed
and back-ported the last known version of your patchset. I'm happy to 
report that the 100% reproducable leak that we were seeing before
cannot be reproduced. As expected, given review of the code. I have 
not been able to test the final driver-specific patches from your 
patchset, but up to and including

[PATCH 12/18] param: simple locking for sysfs-writable charp parameters

they can all have a:

Tested-by: Phil Carmody <ext-phil.2.carmody@...ia.com>

I'm quite interested to see these pushed into the mainline so that I
can cherry-pick final versions for our internal tree, do you have any 
schedule for that?

Cheers,
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/