linux-kernel - Re: [PATCH] Staging: memrar: Moved memrar_allocator struct into memrar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Jun 2010 15:00:03 -0700
From:	Greg KH <greg@...ah.com>
To:	Henri Häkkinen <henuxd@...il.com>
Cc:	gregkh@...e.de, ossama.othman@...el.com,
	devel@...versdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: memrar: Moved memrar_allocator struct into
 memrar_allocator.c

On Mon, Jun 14, 2010 at 02:54:33PM +0300, Henri Häkkinen wrote:
> Forward declared memrar_allocator in memrar_allocator.h and moved it
> to memrar_allocator.c file.  Implemented memrar_allocator_capacity() and
> memrar_allocator_largest_free_area().

Um, did you try building the code after this patch?  It fails in bad
ways:

  CC [M]  drivers/staging/memrar/memrar_handler.o
drivers/staging/memrar/memrar_handler.c: In function ‘memrar_init_rar_resources’:
drivers/staging/memrar/memrar_handler.c:352:2: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c: In function ‘memrar_get_stat’:
drivers/staging/memrar/memrar_handler.c:548:25: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c:550:23: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c:551:35: error: dereferencing pointer to incomplete type
drivers/staging/memrar/memrar_handler.c:552:25: error: dereferencing pointer to incomplete type

Please always build the patches you send out.  I can't take
this one obviously :(

Care to fix it up?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/