linux-kernel - Re: [PATCH] initialise DMA engine before MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jun 2010 08:47:43 +0200
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] initialise DMA engine before MMC

2010/6/7 Guennadi Liakhovetski <g.liakhovetski@....de>:

> To use DMA engine based DMA with MMC in a non-modular build, the DMA
> engine has to initialise before MMC.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> ---
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 91874e0..b713e75 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -92,6 +92,7 @@ obj-$(CONFIG_EISA)            += eisa/
>  obj-y                          += lguest/
>  obj-$(CONFIG_CPU_FREQ)         += cpufreq/
>  obj-$(CONFIG_CPU_IDLE)         += cpuidle/
> +obj-$(CONFIG_DMA_ENGINE)       += dma/
>  obj-$(CONFIG_MMC)              += mmc/
>  obj-$(CONFIG_MEMSTICK)         += memstick/
>  obj-$(CONFIG_NEW_LEDS)         += leds/
> @@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO)                += crypto/
>  obj-$(CONFIG_SUPERH)           += sh/
>  obj-$(CONFIG_ARCH_SHMOBILE)    += sh/
>  obj-$(CONFIG_GENERIC_TIME)     += clocksource/
> -obj-$(CONFIG_DMA_ENGINE)       += dma/
>  obj-$(CONFIG_DCA)              += dca/
>  obj-$(CONFIG_HID)              += hid/
>  obj-$(CONFIG_PPC_PS3)          += ps3/

What I did was to move my DMA engines to subsystem_initcall(), with this
approach I would have had to rearrange a lot of subsystems I think.

But if it's easier for you this way by all means do it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/