linux-kernel - Re: [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Jun 2010 17:25:35 +0800
From:	Cong Wang <amwang@...hat.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx

On 06/28/10 17:08, David Rientjes wrote:
> On Sun, 27 Jun 2010, Amerigo Wang wrote:
>
>> From: Amerigo Wang<amwang@...hat.com>
>> Date: Mon, 28 Jun 2010 10:42:28 +0800
>>
>> When I use make LOCALVERSION=local and LOCALVERSION_AUTO is not set,
>> I got "2.6.35-rc3local". It is supposed to be "2.6.35-rc3-local".
>>
>
> No, a `-' is not implied when using LOCALVERSION=.

But in your patch description, you said:

     Without CONFIG_LOCALVERSION_AUTO, "make" results in v2.6.32-rc4+
     unless the repository is at the Linux v2.6.32-rc4 commit (in which
     case the version would be v2.6.32-rc4).  If "make LOCALVERSION=kbuild"
     were used, it results in v2.6.32-rc4-kbuild.

So, shouldn't that be "make LOCALVERSION=-kbuild"?

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/