linux-kernel - Re: Subject: [PATCH] arm: fix KConfig warning for mach-mx25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 Jun 2010 08:58:17 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Peter Hüwe <PeterHuewe@....de>
Cc:	Sascha Hauer <kernel@...gutronix.de>,
	Russell King <linux@....linux.org.uk>,
	Baruch Siach <baruch@...s.co.il>,
	Eric Bénard <eric@...rea.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Russell King <rmk+kernel@....linux.org.uk>,
	linux-kbuild@...r.kernel.org
Subject: Re: Subject: [PATCH] arm: fix KConfig warning for mach-mx25

Hiho,

[added linux-kbuild@...r.kernel.org to Cc:]

On Tue, Jun 29, 2010 at 12:05:20AM +0200, Peter Hüwe wrote:
> From: Peter Huewe <peterhuewe@....de
> 
> This patch fixes a KConfig warning:
> "arch/arm/mach-mx25/Kconfig:18:warning: choice value used outside its
> choice group"
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>
The problem also goes away when renaming one of the two
MACH_EUKREA_MBIMXSD_BASEBOARD (the other MACH_EUKREA_MBIMXSD_BASEBOARD
is in arch/arm/mach-mx3/Kconfig).  AFAIK Eric already sent a patch to
fix this.  I think this is the real issue, I don't know why the warning
goes away with your patch.

Nevertheless I like your patch.  And note there are two other variables
in arch/arm/mach-mx2 that could benefit from the same "fix".  (But as I
moved this file in my tree I suggest to wait until my changes hit Linus'
tree and then fix arch/arm/mach-imx/Kconfig.)

Best regards
Uwe

> ---
> KernelVersion: linux-next-20100628
>  arch/arm/mach-mx25/Kconfig |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-mx25/Kconfig b/arch/arm/mach-mx25/Kconfig
> index 3a6668e..2f436ed 100644
> --- a/arch/arm/mach-mx25/Kconfig
> +++ b/arch/arm/mach-mx25/Kconfig
> @@ -15,8 +15,7 @@ choice
>  	default MACH_EUKREA_MBIMXSD_BASEBOARD
>  
>  config MACH_EUKREA_MBIMXSD_BASEBOARD
> -	prompt "Eukrea MBIMXSD development board"
> -	bool
> +	bool "Eukrea MBIMXSD development board"
>  	help
>  	  This adds board specific devices that can be found on Eukrea's
>  	  MBIMXSD evaluation board.
> -- 
> 1.7.1

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/