linux-kernel - Re: [PATCH 25/33] Removing dead CORGI_SSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Jul 2010 11:58:13 +0200
From:	Kristoffer Ericson <kristoffer.ericson@...il.com>
To:	Christoph Egger <siccegge@...fau.de>
Cc:	Eric Miao <eric.y.miao@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Pavel Machek <pavel@....cz>,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Uwe Kleine-K??nig <u.kleine-koenig@...gutronix.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	vamos@...informatik.uni-erlangen.de
Subject: Re: [PATCH 25/33] Removing dead CORGI_SSP_DEPRECATED

On Wed, Jun 30, 2010 at 06:01:56PM +0200, Christoph Egger wrote:
> CORGI_SSP_DEPRECATED doesn't exist in Kconfig, therefore removing all
> references for it from the source code.
> 
> Signed-off-by: Christoph Egger <siccegge@...fau.de>

Cant see anything wrong with this.

acked-by: Kristoffer Ericson <kristoffer.ericson@...il.com>

> ---
>  arch/arm/mach-pxa/sharpsl_pm.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c
> index 582701e..d8c5301 100644
> --- a/arch/arm/mach-pxa/sharpsl_pm.c
> +++ b/arch/arm/mach-pxa/sharpsl_pm.c
> @@ -180,17 +180,12 @@ int sharpsl_pm_pxa_read_max1111(int channel)
>  	if (machine_is_tosa())
>  	    return 0;
>  
> -#ifdef CONFIG_CORGI_SSP_DEPRECATED
> -	return corgi_ssp_max1111_get((channel << MAXCTRL_SEL_SH) | MAXCTRL_PD0 | MAXCTRL_PD1
> -			| MAXCTRL_SGL | MAXCTRL_UNI | MAXCTRL_STR);
> -#else
>  	extern int max1111_read_channel(int);
>  
>  	/* max1111 accepts channels from 0-3, however,
>  	 * it is encoded from 0-7 here in the code.
>  	 */
>  	return max1111_read_channel(channel >> 1);
> -#endif
>  }
>  
>  static int get_percentage(int voltage)
> -- 
> 1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/