lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Jul 2010 09:15:28 +0800 From: Jeremy Kerr <jk@...abs.org> To: Arnd Bergmann <arnd@...db.de> Cc: linux-kernel@...r.kernel.org, John Kacur <jkacur@...hat.com>, Frederic Weisbecker <fweisbec@...il.com>, Christoph Hellwig <hch@....de>, linuxppc-dev@...abs.org Subject: Re: [PATCH 06/18] spufs: use llseek in all file operations Hi Arnd, > The default for llseek is changing, so we need > explicit operations everywhere. Looks good, but: > @@ -2151,7 +2166,7 @@ static ssize_t spufs_ibox_info_read(struct file *file, char __user *buf, > static const struct file_operations spufs_ibox_info_fops = { > .open = spufs_info_open, > .read = spufs_ibox_info_read, > - .llseek = generic_file_llseek, > + .llseek = no_llseek, > }; > > static ssize_t __spufs_wbox_info_read(struct spu_context *ctx, > @@ -2194,7 +2209,7 @@ static ssize_t spufs_wbox_info_read(struct file *file, char __user *buf, > static const struct file_operations spufs_wbox_info_fops = { > .open = spufs_info_open, > .read = spufs_wbox_info_read, > - .llseek = generic_file_llseek, > + .llseek = no_llseek, > }; > Why the change in behaviour for the mbox info files? Cheers, Jeremy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists