linux-kernel - Re: [PATCH] classmate-laptop: make needlessly global symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 7 Jul 2010 23:42:27 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Daniel Oliveira Nascimento <don@...t.com.br>,
	Matthew Garrett <mjg@...hat.com>,
	Richard Purdie <rpurdie@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] classmate-laptop: make needlessly global symbols static

On Thu, Jul 08, 2010 at 09:47:50AM +0800, Axel Lin wrote:
> cmpc_accel_sensitivity_attr is needlessly defined global.
> This patch makes the symbol static.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/platform/x86/classmate-laptop.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 3bf399f..6c63303 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -208,7 +208,7 @@ static ssize_t cmpc_accel_sensitivity_store(struct device *dev,
>  	return strnlen(buf, count);
>  }
>  
> -struct device_attribute cmpc_accel_sensitivity_attr = {
> +static struct device_attribute cmpc_accel_sensitivity_attr = {
>  	.attr = { .name = "sensitivity", .mode = 0660 },
>  	.show = cmpc_accel_sensitivity_show,
>  	.store = cmpc_accel_sensitivity_store
> -- 
> 1.5.4.3
> 
> 
> 

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)