linux-kernel - Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Jul 2010 20:58:11 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Greg KH <greg@...ah.com>
Cc:	linux-usb@...r.kernel.org, Alan Stern <stern@...land.harvard.edu>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>,
	stable <stable@...nel.org>
Subject: Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number

> On Thu, Jul 01, 2010 at 03:42:19PM +0200, Michal Nazarewicz wrote:
>> This commit adds iSerialNumber to all gadgets that use the Mass
>> Storage Function.  It appears that Windows has problems when
>> it is not set.
>>
>> Not to copy the same code all over again, a fsg_string_serial_fill()
>> macro has been added to the storage_common.c file which is now also
>> used in the File Storage Gadget.

On Thu, 08 Jul 2010 20:34:25 +0200, Greg KH <greg@...ah.com> wrote:
> This patch conflicts with the patch in my tree:
> 	Subject: USB: Add a serial number parameter to g_file_storage module

Ah, there it is...  I remembered this patch but couldn't find it so assumed
that it didn't make it to your tree after all.  But there it is...

> So, could you fix the above patch up to play nice with your change so
> that I can accept it?

Sure thing.  If I won't post it within 2h I'll do that after the weekend
(read Monday).

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/