linux-kernel - Re: [PATCH] usb: gadget: #include device.h in gadget.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 08 Jul 2010 23:12:41 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Patrick Pannuto <ppannuto@...eaurora.org>
CC:	dbrownell@...rs.sourceforge.net, gregkh@...e.de,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	sboyd@...eaurora.org
Subject: Re: [PATCH] usb: gadget: #include device.h in gadget.h

Hello.

Patrick Pannuto wrote:

> gadget.h uses structures defined in device.h, it must include it. In
> most cases, gadget.h is preceded by linux/platform_device.h, but if
> you are grouping headers sanely, device.h may not be pulled in until
> *after* gadget (e.g. mach/msm_device.h), thus gadget.h should not
> rely on something else #including device.h

    Sigh, I've already submitted a more complete patch, adding 6 #include's 
but it seems that prevailing opinion in this list is to leave things as they 
are in the header, and deal with the fallout wherever it's used.

[...]

> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index bbf45d5..ddca035 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -15,6 +15,8 @@
>  #ifndef __LINUX_USB_GADGET_H
>  #define __LINUX_USB_GADGET_H
>  
> +#include <linux/device.h>
> +

    Besides, this is not against the recent kernel -- there should be #include 
<linux/slab.h> here.

>  struct usb_ep;
>  
>  /**

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/