linux-kernel - mmu notifier calls in apply_to_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 09 Jul 2010 08:06:20 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andrea Arcangeli <aarcange@...hat.com>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: mmu notifier calls in apply_to_page_range()

I just noticed that the original mmu notifier change (cddb8a5c14a) adds
calls to mmu_notifier_invalidate_range_start/end to
apply_to_page_range().  This doesn't seem correct to me, since
apply_to_page_range can perform arbitrary operations to the range of
pages, not just invalidation of the pages.  It seems to me that the
appropriate mmu notifiers should be called either around the call to
apply_to_page_range(), or from within the callback function.

Andrea, what's the rationale for mmu_notifier_invalidate_range_start/end
here?

Thanks,
    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/