linux-kernel - Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Jul 2010 18:21:38 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Hans de Goede <hdegoede@...hat.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paul Goyette <paul@...oppee.com>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant 
 temperature sensors

On Sun, 11 Jul 2010 09:16:58 -0700, Guenter Roeck wrote:
> On Sun, Jul 11, 2010 at 11:31:06AM -0400, Joe Perches wrote:
> > On Sun, 2010-07-11 at 07:53 -0700, Guenter Roeck wrote:
> > > +	for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) {
> > > +		if (manid == jc42_chips[i].manid
> > > +		    && (devid & jc42_chips[i].devid_mask) ==
> > > +					    jc42_chips[i].devid) {
> > > +			strlcpy(info->type, "jc42", I2C_NAME_SIZE);
> > > +			return 0;
> > > +		}
> > > +	}
> > 
> > Decidedly trivial:
> > 
> > Kernel style seems to prefer having logical tests at
> > end of line rather than start of line.
>
> Ok. Would be nice to have checkpatch.pl complain about it, though,
> if it is a to-be-enforced rule.

Please, not again. This has been discussed before, with the conclusion
that nobody really cares and we don't want to add pointless warnings to
checkpatch.pl, which in the end will just dissuade people from running
the script and/or contributing to the kernel at all.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/