lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 13 Jul 2010 10:25:01 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Joe Perches <joe@...ches.com>
CC:	Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net
Subject: Re: [PATCH 08/36] drivers/ieee1394: Remove unnecessary casts of private_data

Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/ieee1394/dv1394.c    |    4 ++--
>  drivers/ieee1394/raw1394.c   |    4 ++--
>  drivers/ieee1394/video1394.c |    6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/ieee1394/dv1394.c b/drivers/ieee1394/dv1394.c
> index f8fcbd0..c5a031b 100644
> --- a/drivers/ieee1394/dv1394.c
> +++ b/drivers/ieee1394/dv1394.c
> @@ -172,7 +172,7 @@ static DEFINE_SPINLOCK(dv1394_cards_lock);
>  
>  static inline struct video_card* file_to_video_card(struct file *file)
>  {
> -	return (struct video_card*) file->private_data;
> +	return file->private_data;
[...]

Committed to linux1394-2.6.git.

drivers/ieee1394/ is both frozen and obsolete code that is scheduled for
removal.  But this change is obvious enough to be applied nevertheless
before that code finally goes away.
-- 
Stefan Richter
-=====-==-=- -=== -==-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ