| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Jul 2010 12:02:46 +0200 From: Oliver Neukum <oneukum@...e.de> To: Changli Gao <xiaosuo@...il.com> Cc: "Greg Kroah-Hartman" <gregkh@...e.de>, "Jike Song" <albcamus@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] drivers: code cleanups Am Mittwoch, 14. Juli 2010, 11:42:56 schrieb Changli Gao: > drivers: code cleanups > > the first three goto clauses caused kfree(NULL), and the error code returned > by kset->uevent_ops->uevent() wasn't passed to the caller of show_uevent(). > This patch also eliminates the unnecessary initializations of env and count. This is not a good idea. If you are indeed fixing a bug of not returning an error, make a patch that does that. The other parts of your patch really are no improvement, because they make things harder to maintain if additional cleanups or locking must ever be added. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists