linux-kernel - Re: BUG in drivers/dma/ioat/dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Jul 2010 22:41:02 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	Chris Li <lkml@...isli.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: BUG in drivers/dma/ioat/dma_v2.c:314

On 7/9/2010 5:09 PM, David Woodhouse wrote:
> Actually, given that we know the chipset, can't we just read the VT BARs
> directly from config space and check that the base address of the IOMMU
> we get is the right one for the I/OAT device?
>
> Something like...
>
>     pci_read_config_dword( ("0:0.0") , 0x48,&vtbar );
>     if (drhd->base_address != vtbar)
> 	WARN();

Ok, here is a patch that takes this approach.

David, will you sign off on this?

Chris, I'll add a tested-by line if you can give this a shot.

Thanks,
Dan

View attachment "ioat-catch-broken-vtd-v4.patch" of type "text/plain" (5353 bytes)