linux-kernel - Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jul 2010 10:29:38 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Kulikov Vasiliy <segooon@...il.com>
CC:	kernel-janitors@...r.kernel.org, Greg Ungerer <gerg@...inux.org>,
	John Kacur <jkacur@...hat.com>, Tejun Heo <tj@...nel.org>,
	Maxim Kuvyrkov <maxim@...esourcery.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of
 pointers in printk()

Hi Kulikov,

Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>

Acked-by: Greg Ungerer <gerg@...inux.org>

Do you want me to push this to Linus via the m68knommu git tree?

Regards
Greg



> ---
>  arch/m68knommu/kernel/process.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
> index 6aa6613..1096c0e 100644
> --- a/arch/m68knommu/kernel/process.c
> +++ b/arch/m68knommu/kernel/process.c
> @@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
>  		fp->d0, fp->d1, fp->d2, fp->d3);
>  	printk(KERN_EMERG "d4: %08lx    d5: %08lx    a0: %08lx    a1: %08lx\n",
>  		fp->d4, fp->d5, fp->a0, fp->a1);
> -	printk(KERN_EMERG "\nUSP: %08x   TRAPFRAME: %08x\n",
> -		(unsigned int) rdusp(), (unsigned int) fp);
> +	printk(KERN_EMERG "\nUSP: %08x   TRAPFRAME: %p\n",
> +		(unsigned int) rdusp(), fp);
>  
>  	printk(KERN_EMERG "\nCODE:");
>  	tp = ((unsigned char *) fp->pc) - 0x20;
>  	for (sp = (unsigned long *) tp, i = 0; (i < 0x40);  i += 4) {
>  		if ((i % 0x10) == 0)
> -			printk(KERN_EMERG "%08x: ", (int) (tp + i));
> +			printk(KERN_EMERG "%p: ", tp + i);
>  		printk("%08x ", (int) *sp++);
>  	}
>  	printk(KERN_EMERG "\n");
> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
>  	tp = ((unsigned char *) fp) - 0x40;
>  	for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
>  		if ((i % 0x10) == 0)
> -			printk(KERN_EMERG "%08x: ", (int) (tp + i));
> +			printk(KERN_EMERG "%p: ", tp + i);
>  		printk("%08x ", (int) *sp++);
>  	}
>  	printk(KERN_EMERG "\n");
> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
>  	tp = (unsigned char *) (rdusp() - 0x10);
>  	for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
>  		if ((i % 0x10) == 0)
> -			printk(KERN_EMERG "%08x: ", (int) (tp + i));
> +			printk(KERN_EMERG "%p: ", tp + i);
>  		printk("%08x ", (int) *sp++);
>  	}
>  	printk(KERN_EMERG "\n");


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/