| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Jul 2010 22:43:15 +0400 From: Kulikov Vasiliy <segooon@...il.com> To: kernel-janitors@...r.kernel.org Cc: Colin Cross <ccross@...roid.com>, Erik Gilling <konkers@...roid.com>, Olof Johansson <olof@...om.net>, Russell King <linux@....linux.org.uk>, linux-tegra@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: [PATCH 1/8] arm/mach-tegra: fix unsigned calcs divider_u71 is unsigned, so this check is buggy: if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0) If divider_u71 is 0 or 1 both checks are lying. So, it does not produce a buggy answer, but it is confusing. Signed-off-by: Kulikov Vasiliy <segooon@...il.com> --- arch/arm/mach-tegra/tegra2_clocks.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-tegra/tegra2_clocks.c b/arch/arm/mach-tegra/tegra2_clocks.c index 4261632..64df5b4 100644 --- a/arch/arm/mach-tegra/tegra2_clocks.c +++ b/arch/arm/mach-tegra/tegra2_clocks.c @@ -149,7 +149,7 @@ static int clk_div71_get_divider(struct clk *c, unsigned long rate) divider_u71 = DIV_ROUND_UP(c->rate * 2, rate); - if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0) + if (divider_u71 > 2 + 255 || divider_u71 < 2) return -EINVAL; return divider_u71 - 2; -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists