linux-kernel - Re: [RFC][PATCH 14/16] writeback: move bdi threads exiting logic to the forker thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jul 2010 03:02:31 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 14/16] writeback: move bdi threads exiting logic to
 the forker thread

Yes, only killing threads from the caller is much better, that's how
the kthread API is supposed to be used anyway.

>  static void bdi_queue_work(struct backing_dev_info *bdi,
>  		struct wb_writeback_work *work)
>  {
> +	bool wakeup_default = false;
> +
>  	trace_writeback_queue(bdi, work);
>  
>  	spin_lock(&bdi->wb_lock);
>  	list_add_tail(&work->list, &bdi->work_list);
> -	spin_unlock(&bdi->wb_lock);
> -
>  	/*
>  	 * If the default thread isn't there, make sure we add it. When
>  	 * it gets created and wakes up, we'll run this work.
>  	 */
> -	if (unlikely(!bdi->wb.task)) {
> +	if (unlikely(!bdi->wb.task))
> +		wakeup_default = true;
> +	else
> +		wake_up_process(bdi->wb.task);
> +	spin_unlock(&bdi->wb_lock);
> +
> +	if (wakeup_default) {
>  		trace_writeback_nothread(bdi, work);
>  		wake_up_process(default_backing_dev_info.wb.task);

Why not simply do the defaul thread wakeup under wb_lock, too?
It keeps the code a lot simpler, and this is not a typical path anyway.

>  		if (dirty_writeback_interval) {
> +			unsigned long wait_jiffies;
> +
>  			wait_jiffies = msecs_to_jiffies(dirty_writeback_interval * 10);
>  			schedule_timeout(wait_jiffies);

No real need for a local variable here.

> @@ -364,7 +395,7 @@ static int bdi_forker_thread(void *ptr)
>  		if (!list_empty(&me->bdi->work_list))
>  			__set_current_state(TASK_RUNNING);
>  
> -		if (!fork) {
> +		if (!fork && !kill) {

I think the code here would be a lot cleaner if you implement the
suggestion I have for the forking restructuring.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/