linux-kernel - Re: emacs and "linux" coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jul 2010 12:10:09 +0300 (EEST)
From:	Dimitrios Apostolou <jimis@....net>
To:	Ted Ts'o <tytso@....edu>
cc:	Randy Dunlap <rdunlap@...otime.net>,
	Krzysztof Halasa <khc@...waw.pl>, linux-kernel@...r.kernel.org,
	Dan Nicolaescu <dann@....org>
Subject: Re: emacs and "linux" coding style

On Sun, 18 Jul 2010, Ted Ts'o wrote:
> On Sat, Jul 17, 2010 at 06:51:46AM -0700, Randy Dunlap wrote:
>> On Sat, 17 Jul 2010 11:21:03 +0200 Krzysztof Halasa wrote:
>>
>>> Dimitrios Apostolou <jimis@....net> writes:
>>>
>>>> static void update_group_shares_cpu(struct task_group *tg, int cpu,
>>>>                                     unsigned long sd_shares,
>>>>                                     unsigned long sd_rq_weight,
>>>>                                     unsigned long *usd_rq_weight)
>>>> {
>>>
>>> From a technical POV the above should not have any tabs, the parameters
>>> should be aligned with spaces only.
>>
>> fwiw, it seems that you agree with Ted.
>
> Actually, what my code use is tabs with a tab stop of 8 followed by
> enough spaces (< 7) to align function parameters and to align
> open/close parenthesis in C expression line wrap.

FWIW that way will show the parameters unaligned to anyone using a 
different tab length. There is one way to align such lines properly:

You indent with as many tabs as the previous line has and you use all 
spaces (perhaps more than 8) afterwards, to align parameters where you 
want them. In the example above that would use 0 tabs, all spaces...

Unfortunately this style is not the default to any editor I have seen, 
even though it really makes code readable with any tab length. Even for 
emacs you have to customize your config file:
http://www.emacswiki.org/emacs/SmartTabs


Dimitris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/