linux-kernel - Re: [PATCHv4 5/5] USB: gadget: file_storage: serial parameter even if not test mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Jul 2010 10:14:32 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <m.nazarewicz@...sung.com>
cc:	linux-usb@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	David Brownell <david-b@...bell.net>, Greg KH <greg@...ah.com>,
	<linux-kernel@...r.kernel.org>,
	Yann Cantin <yann.cantin@...oste.net>
Subject: Re: [PATCHv4 5/5] USB: gadget: file_storage: serial parameter even
 if not test mode

On Thu, 22 Jul 2010, Michal Nazarewicz wrote:

> Moved the serial parameter handling code out of "#ifdef
> CONFIG_USB_FILE_STORAGE_TEST".
> 
> This modifies Yann Cantin's commit "USB: Add a serial number
> parameter to g_file_storage" module as per Alan Stern's request.
> 
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Yann Cantin <yann.cantin@...oste.net>
> ---
> Alan Stern wrote:
> > I have only one objection to this [Yann Cantin's] patch: The new
> > parameter's name should be "serial", not "serial_parm".
> 
> Alan Stern wrote:
> > The serial number parameter is important enough that it should be
> > available even on builds without CONFIG_USB_FILE_STORAGE_TEST.
> 
>  drivers/usb/gadget/file_storage.c |   20 +++++++++++---------
>  1 files changed, 11 insertions(+), 9 deletions(-)

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/