linux-kernel - Re: [PATCH v4] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Jul 2010 10:17:53 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Gregory Bean <gbean@...eaurora.org>
Cc:	akpm@...ux-foundation.org, david-b@...bell.net, khali@...ux-fr.org,
	linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] gpio: sx150x: Add Semtech I2C sx150x gpio expander
 driver.

On Thu, 22 Jul 2010 10:12:51 -0700 Gregory Bean wrote:

>  drivers/gpio/Kconfig       |   11 +
>  drivers/gpio/Makefile      |    1 +
>  drivers/gpio/sx150x.c      |  645 ++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/i2c/sx150x.h |   78 ++++++
>  4 files changed, 735 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/gpio/sx150x.c
>  create mode 100644 include/linux/i2c/sx150x.h
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 7face91..f623953 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -195,6 +195,17 @@ config GPIO_PCF857X
>  	  This driver provides an in-kernel interface to those GPIOs using
>  	  platform-neutral GPIO calls.
>  
> +config GPIO_SX150X
> +	bool "Semtech SX150x I2C GPIO expander"
> +	depends on I2C=y
> +	default n
> +	help
> +	  Say yes here to provide support for Semtech SX150-series I2C
> +	  GPIO expanders. Compatible models include:

Just curious, not complaining, but why does this driver (and some others)
need to be built-in instead of having the option of being built as a
loadable module?


> +	  8 bits:  sx1508q
> +	  16 bits: sx1509q
> +
>  config GPIO_TC35892
>  	bool "TC35892 GPIOs"
>  	depends on MFD_TC35892




---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/