linux-kernel - Re: [PATCH] fix warning: us_to_pm_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 24 Jul 2010 10:57:17 +0200
From:	Florian Mickler <florian@...kler.org>
To:	florian@...kler.org
Cc:	linux-acpi@...r.kernel.org, Len Brown <lenb@...nel.org>,
	Venkatesh Pallipadi <venki@...gle.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix warning: us_to_pm_timer_ticks defined but not used

On Fri, 23 Jul 2010 17:59:02 +0200
florian@...kler.org wrote:

> Move it under the same ifdef as its sole caller is.
> 
> Signed-off-by: Florian Mickler <florian@...kler.org>
> ---
>  drivers/acpi/processor_idle.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index b1b3856..8525070 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -80,10 +80,6 @@ module_param(nocst, uint, 0000);
>  static unsigned int latency_factor __read_mostly = 2;
>  module_param(latency_factor, uint, 0644);
>  
> -static u64 us_to_pm_timer_ticks(s64 t)
> -{
> -	return div64_u64(t * PM_TIMER_FREQUENCY, 1000000);
> -}
>  /*
>   * IBM ThinkPad R40e crashes mysteriously when going into C2 or C3.
>   * For now disable this. Probably a bug somewhere else.
> @@ -685,6 +681,12 @@ static int acpi_processor_get_power_info(struct acpi_processor *pr)
>  }
>  
>  #ifdef CONFIG_ACPI_PROCFS
> +
> +static u64 us_to_pm_timer_ticks(s64 t)
> +{
> +	return div64_u64(t * PM_TIMER_FREQUENCY, 1000000);
> +}
> +
>  static int acpi_processor_power_seq_show(struct seq_file *seq, void *offset)
>  {
>  	struct acpi_processor *pr = seq->private;

Ah, I just saw the Patch from KOSAKI Motohiro ([patch 1/2] acpi: fix
unused function warning) to the same effect. 
I should have checked the mailinglist before sending this :)

Sorry for the noise,

Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/