linux-kernel - Re: [PATCH] x86, mrst: remove unused mrst_identify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 Jul 2010 22:04:45 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Feng Tang <feng.tang@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()

Jacob, is this obsolete or something that will be needed in future versions?

It seems that either __mrst_cpu_chip should be killed off, or read-only
users should be using the inline instead of __mrst_cpu_chip directly.

	-hpa

On 07/24/2010 09:50 PM, Javier Martinez Canillas wrote:
> mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>
> ---
>  arch/x86/include/asm/mrst.h |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h
> index 1635074..0d0e702 100644
> --- a/arch/x86/include/asm/mrst.h
> +++ b/arch/x86/include/asm/mrst.h
> @@ -26,10 +26,6 @@ enum mrst_cpu_type {
>  };
>  
>  extern enum mrst_cpu_type __mrst_cpu_chip;
> -static enum mrst_cpu_type mrst_identify_cpu(void)
> -{
> -	return __mrst_cpu_chip;
> -}
>  
>  enum mrst_timer_options {
>  	MRST_TIMER_DEFAULT,


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/