linux-kernel - Re: [PATCH] mm: Check NULL pointer Dereference in mm/filemap.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 27 Jul 2010 16:10:49 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	wzt.wzt@...il.com
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm: Check NULL pointer Dereference in mm/filemap.c

On Mon, 26 Jul 2010 16:25:42 +0800
wzt.wzt@...il.com wrote:

> mapping->a_ops->direct_IO() is not checked, if it's a NULL pointer, 
> that will casue an oops. pagecache_write_begin/end is exported to
> other functions, so they need to check null pointer before use them. 
> 

The patch checks a lot more things than ->directIO!

It would be best to not add this overhead if possible.  Did you
actually observe an oops?  If so, please fully describe it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/