| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Jul 2010 21:41:07 -0700 From: Yinghai Lu <yinghai@...nel.org> To: Corey Minyard <minyard@....org> CC: Andrew Morton <akpm@...ux-foundation.org>, Matthew Garrett <mjg@...hat.com>, Len Brown <len.brown@...el.com>, Myron Stowe <myron.stowe@...com>, openipmi-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ipmi: Fix memleaking for add_smi when duplicating happen On 07/26/2010 07:05 PM, Corey Minyard wrote: > Please run this through checkpatch, as it has coding style violations. yhlu@...ux-siqj:~/xx/xx/kernel/tip/linux-2.6> ./scripts/checkpatch.pl patches/ipmi_reg_size.patch total: 0 errors, 0 warnings, 105 lines checked patches/ipmi_reg_size.patch has no obvious style problems and is ready for submission. yhlu@...ux-siqj:~/xx/xx/kernel/tip/linux-2.6> > > Also, this patch appears to fix bugs in addition to adding the print. > Can we have a separate patch for that? in the comment log, i already mentioned that. will separate it to twol > > I'm also not clear on the reason for this. I believe all this > information is already available in /proc/ipmi/<if#>/params. I don't > think there is a strong reason to print it to the log. then why there is printing for ACPI path and pci path? Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists