linux-kernel - Re: [PATCH net-next 2/3] drivers/net/bfin_mac.c: Use pr_<level>, netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Jul 2010 20:17:19 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Michael Hennerich <michael.hennerich@...log.com>,
	uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] drivers/net/bfin_mac.c: Use pr_<level>, 
	netdev_<level>

On Thu, Jul 29, 2010 at 19:58, Joe Perches wrote:
> Add and use pr_fmt, pr_<level> and netdev_<level>

your changelog says add pr_fmt, but i dont see it in the patch ...

> @@ -833,8 +830,7 @@ static void bfin_tx_hwtstamp(struct net_device *netdev, struct sk_buff *skb)
>                       (--timeout_cnt))
>                        udelay(1);
>                if (timeout_cnt == 0)
> -                       printk(KERN_ERR DRV_NAME
> -                                       ": fails to timestamp the TX packet\n");
> +                       pr_err("failed to timestamp the TX packet\n");

this func has a net_device, so cant you use netdev_err here ?

> @@ -1102,8 +1097,7 @@ static void bfin_mac_rx(struct net_device *dev)
>
>        new_skb = dev_alloc_skb(PKT_BUF_SZ + NET_IP_ALIGN);
>        if (!new_skb) {
> -               printk(KERN_NOTICE DRV_NAME
> -                      ": rx: low on mem - packet dropped\n");
> +               pr_notice("rx: low on mem - packet dropped\n");

same here

otherwise this patch looks good
-mike