linux-kernel - Re: [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Jul 2010 21:05:58 +0200
From:	Kristoffer Ericson <kristoffer.ericson@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] jornada720_bl/jornada720_lcd: make needlessly global
 symbols static

On Fri, Jul 30, 2010 at 11:00:23AM +0800, Axel Lin wrote:
> The following symbols are needlessly defined global:
> jornada_bl_init
> jornada_bl_exit
> jornada_lcd_init
> jornada_lcd_exit
> 
> This patch makes the symbols static.

Acked-by: Kristoffer Ericson <kristoffer.ericson@...il.com>
Thx.

> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/video/backlight/jornada720_bl.c  |    4 ++--
>  drivers/video/backlight/jornada720_lcd.c |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
> index 60e1d28..a20a01a 100644
> --- a/drivers/video/backlight/jornada720_bl.c
> +++ b/drivers/video/backlight/jornada720_bl.c
> @@ -146,12 +146,12 @@ static struct platform_driver jornada_bl_driver = {
>  	},
>  };
>  
> -int __init jornada_bl_init(void)
> +static int __init jornada_bl_init(void)
>  {
>  	return platform_driver_register(&jornada_bl_driver);
>  }
>  
> -void __exit jornada_bl_exit(void)
> +static void __exit jornada_bl_exit(void)
>  {
>  	platform_driver_unregister(&jornada_bl_driver);
>  }
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 8fe0181..9fd7af2 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -135,12 +135,12 @@ static struct platform_driver jornada_lcd_driver = {
>  	},
>  };
>  
> -int __init jornada_lcd_init(void)
> +static int __init jornada_lcd_init(void)
>  {
>  	return platform_driver_register(&jornada_lcd_driver);
>  }
>  
> -void __exit jornada_lcd_exit(void)
> +static void __exit jornada_lcd_exit(void)
>  {
>  	platform_driver_unregister(&jornada_lcd_driver);
>  }
> -- 
> 1.5.4.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/