| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 31 Jul 2010 08:36:32 -0500 From: Matt Mackall <mpm@...enic.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Richard Kennedy <richard@....demon.co.uk>, Andrew Morton <akpm@...ux-foundation.org>, lkml <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] random: reorder struct entropy_store to remove padding on 64bits On Sat, 2010-07-31 at 19:58 +0800, Herbert Xu wrote: > On Wed, Jul 28, 2010 at 11:02:28AM -0500, Matt Mackall wrote: > > On Wed, 2010-07-28 at 10:32 +0100, Richard Kennedy wrote: > > > Re-order structure entropy_store to remove 8 bytes of padding on > > > 64 bit builds, so shrinking this structure from 72 to 64 bytes > > > and allowing it to fit into one cache line. > > > > I have a vague memory that we reordered things so that the r/w bits > > would be on a separate cache line than the r/o bits. But as we never > > added the alignment primitives to actually enforce that, I guess it > > doesn't matter much. > > > > > Signed-off-by: Richard Kennedy <richard@....demon.co.uk> > > > > Signed-off-by: Matt Mackall <mpm@...enic.com> > > Patch applied. Thanks! Oops, I forgot to cc: you on this and Andrew queued it. Andrew, I've been queueing the RNG bits through Herbert's crypto tree lately. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists